-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: staking claim [SW-160] #4167
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9a2301a
feat: add claim decoding
compojoom 1613771
fix: stake deposit tx info should display amount
compojoom 0953460
fix: label for rewards
compojoom 6eb82ac
fix: use kiln’s production widget url
compojoom 5d8367f
fix: use test widget url when on a testchain
compojoom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
src/features/stake/components/StakingConfirmationTx/Withdraw.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
import { Stack } from '@mui/material' | ||
import FieldsGrid from '@/components/tx/FieldsGrid' | ||
import type { | ||
NativeStakingWithdrawConfirmationView, | ||
StakingTxWithdrawInfo, | ||
} from '@safe-global/safe-gateway-typescript-sdk' | ||
import TokenAmount from '@/components/common/TokenAmount' | ||
|
||
type StakingOrderConfirmationViewProps = { | ||
order: NativeStakingWithdrawConfirmationView | StakingTxWithdrawInfo | ||
} | ||
|
||
const StakingConfirmationTxWithdraw = ({ order }: StakingOrderConfirmationViewProps) => { | ||
return ( | ||
<Stack gap={2}> | ||
<FieldsGrid title="Receive"> | ||
{' '} | ||
<TokenAmount | ||
value={order.rewards} | ||
tokenSymbol={order.tokenInfo.symbol} | ||
decimals={order.tokenInfo.decimals} | ||
logoUri={order.tokenInfo.logoUri} | ||
/> | ||
</FieldsGrid> | ||
</Stack> | ||
) | ||
} | ||
|
||
export default StakingConfirmationTxWithdraw |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 11 additions & 2 deletions
13
src/features/stake/components/StakingTxDepositInfo/index.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,17 @@ | ||
import type { StakingTxInfo } from '@safe-global/safe-gateway-typescript-sdk' | ||
import { camelCaseToSpaces } from '@/utils/formatters' | ||
import TokenAmount from '@/components/common/TokenAmount' | ||
|
||
export const StakingTxDepositInfo = ({ info }: { info: StakingTxInfo }) => { | ||
return <>{camelCaseToSpaces(info.type).toLowerCase()}</> | ||
return ( | ||
<> | ||
<TokenAmount | ||
value={info.value} | ||
tokenSymbol={info.tokenInfo.symbol} | ||
decimals={info.tokenInfo.decimals} | ||
logoUri={info.tokenInfo.logoUri} | ||
/> | ||
</> | ||
) | ||
} | ||
|
||
export default StakingTxDepositInfo |
13 changes: 13 additions & 0 deletions
13
src/features/stake/components/StakingTxWithdrawDetails/index.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import { Box } from '@mui/material' | ||
import type { StakingTxWithdrawInfo } from '@safe-global/safe-gateway-typescript-sdk' | ||
import StakingConfirmationTxWithdraw from '@/features/stake/components/StakingConfirmationTx/Withdraw' | ||
|
||
const StakingTxWithdrawDetails = ({ info }: { info: StakingTxWithdrawInfo }) => { | ||
return ( | ||
<Box pl={1} pr={5} display="flex" flexDirection="column" gap={1}> | ||
<StakingConfirmationTxWithdraw order={info} /> | ||
</Box> | ||
) | ||
} | ||
|
||
export default StakingTxWithdrawDetails |
17 changes: 17 additions & 0 deletions
17
src/features/stake/components/StakingTxWithdrawInfo/index.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
import type { StakingTxWithdrawInfo } from '@safe-global/safe-gateway-typescript-sdk' | ||
import TokenAmount from '@/components/common/TokenAmount' | ||
|
||
const StakingTxWithdrawInfo = ({ info }: { info: StakingTxWithdrawInfo }) => { | ||
return ( | ||
<> | ||
<TokenAmount | ||
value={info.rewards} | ||
tokenSymbol={info.tokenInfo.symbol} | ||
decimals={info.tokenInfo.decimals} | ||
logoUri={info.tokenInfo.logoUri} | ||
/> | ||
</> | ||
) | ||
} | ||
|
||
export default StakingTxWithdrawInfo |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can’t these titles be deduced from the txInfo/txConfirmation type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in the call - we currently do this because the app title is a component that is rendered before the modal content and as such it doesn't have access to the txInfo. This would need a refactoring (since you guys are working on the txflow #4157 you can consider it there)