Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Sygnum safe app recovery method [SW-168] #4166

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Feat: Sygnum safe app recovery method [SW-168] #4166

merged 2 commits into from
Sep 19, 2024

Conversation

katspaugh
Copy link
Member

What it solves

Resolves https://www.notion.so/safe-global/Tweak-Recovery-Hub-UI-with-Sygnum-being-live-1b5bde2ee7a841568f05962d9d02c634

Screenshot 2024-09-12 at 16 23 28

How this PR fixes it

Sygnum Safe App will be released soon, so it becomes an active recovery option and not a waitlist.

How to test it

  • Go to Settings -> Security -> Recovery Setup
  • Choose Sygnum
  • Press Open App
  • Check analytics events

Checklist

  • [x ] I've documented how it affects the analytics (if at all) 📊

Copy link

github-actions bot commented Sep 12, 2024

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Sep 12, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 949.58 KB (🟢 -4.64 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Forty-one Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 24.86 KB (🟢 -18 B) 974.44 KB
/403 574 B (🟢 -3 B) 950.14 KB
/404 697 B (🟢 -1 B) 950.26 KB
/_error 230 B (🟡 +2 B) 949.81 KB
/_offline 1.09 KB (🟢 -3 B) 950.67 KB
/addOwner 535 B (🟡 +1 B) 950.1 KB
/address-book 26.11 KB (🟡 +13 B) 975.69 KB
/apps 50.19 KB (🟡 +8 B) 999.77 KB
/apps/bookmarked 446 B (🟡 +1 B) 950.02 KB
/apps/custom 41.8 KB (🟢 -15 B) 991.38 KB
/apps/open 53.58 KB (🟢 -1.15 KB) 1003.16 KB
/balances 30.64 KB (🟢 -356 B) 980.22 KB
/balances/nfts 19.16 KB (🟢 -19 B) 968.74 KB
/cookie 8.76 KB (🟡 +27 B) 958.35 KB
/home 60.32 KB (🟡 +108 B) 1009.9 KB
/imprint 1.38 KB (🟡 +2 B) 950.96 KB
/licenses 4.97 KB (🟢 -3 B) 954.55 KB
/new-safe/advanced-create 35.14 KB (-1 B) 984.72 KB
/new-safe/create 34.4 KB (🟢 -7 B) 983.98 KB
/new-safe/load 16.39 KB (🟢 -25 B) 965.97 KB
/privacy 15.9 KB (🟡 +24 B) 965.48 KB
/settings 450 B (🟢 -1 B) 950.02 KB
/settings/appearance 8.02 KB (🟢 -20 B) 957.6 KB
/settings/cookies 7.64 KB (🟢 -26 B) 957.22 KB
/settings/data 7.54 KB (🟢 -22 B) 957.12 KB
/settings/environment-variables 9.13 KB (🟢 -25 B) 958.71 KB
/settings/modules 9.76 KB (🟢 -20 B) 959.35 KB
/settings/notifications 27.85 KB (🟡 +835 B) 977.43 KB
/settings/safe-apps 25.55 KB (🟢 -11 B) 975.13 KB
/settings/security 8.06 KB (🟢 -26 B) 957.64 KB
/settings/setup 35.96 KB (🟢 -22 B) 985.54 KB
/share/safe-app 9.72 KB (🟢 -1 B) 959.3 KB
/swap 646 B (🟢 -86 B) 950.21 KB
/terms 11.18 KB (🔴 +10.65 KB) 960.77 KB
/transactions 73.83 KB (🟡 +325 B) 1023.42 KB
/transactions/history 73.8 KB (🟡 +326 B) 1023.38 KB
/transactions/messages 39.2 KB (🟡 +43 B) 988.78 KB
/transactions/msg 29.58 KB (🟡 +71 B) 979.16 KB
/transactions/queue 31.3 KB (🟡 +41 B) 980.88 KB
/transactions/tx 21.13 KB (🟡 +69 B) 970.71 KB
/welcome 6.77 KB (🟢 -3 B) 956.35 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Sep 12, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.45% (-0.02% 🔻)
11859/15116
🔴 Branches
59% (-0.02% 🔻)
3042/5156
🟡 Functions
65.82% (-0.03% 🔻)
1885/2864
🟡 Lines
79.89% (-0.02% 🔻)
10701/13394
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / index.tsx
82.35% (-8.82% 🔻)
66.67% (-16.67% 🔻)
50% (-12.5% 🔻)
83.87% (-9.68% 🔻)

Test suite run success

1483 tests passing in 203 suites.

Report generated by 🧪jest coverage report action from 459693b

Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Looks good!

@katspaugh katspaugh changed the title Feat: Sygnum safe app recovery method Feat: Sygnum safe app recovery method [SW-168] Sep 12, 2024
Copy link

@liliya-soroka
Copy link
Member

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh
Copy link
Member Author

@liliya-soroka fixed ✅

@liliya-soroka
Copy link
Member

image cc @TanyaEfremova

@TanyaEfremova
Copy link
Contributor

Can we adjust the style of the card according to design, please? See Figma

Disable the Sygnum option if app is not enabled
@katspaugh
Copy link
Member Author

katspaugh commented Sep 19, 2024

Updated the styles.

Screenshot 2024-09-19 at 12 40 42

@katspaugh katspaugh changed the base branch from dev to release September 19, 2024 10:38
Copy link

github-actions bot commented Sep 19, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh katspaugh merged commit d6cedcb into release Sep 19, 2024
12 of 17 checks passed
@katspaugh katspaugh deleted the sygnum branch September 19, 2024 10:55
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants