Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Consider app category in the searchbar query filter #4147

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

clovisdasilvaneto
Copy link
Contributor

What it solves

Resolves #4088

How this PR fixes it

It adds the tags property from the apps array into the fusion constructor parameters.

How to test it

Type the category you want to search in the safe apps search bar and you'll have the apps filtered not only by the name or description but also category.

Screenshots

Screenshot 2024-09-09 at 16 35 44

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Sep 9, 2024

Copy link

github-actions bot commented Sep 9, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Sep 9, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/apps 50.19 KB (🟡 +6 B) 995.45 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Sep 9, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.39% 11787/15037
🔴 Branches 58.96% 3008/5102
🟡 Functions 65.94% 1880/2851
🟡 Lines 79.79% 10633/13327

Test suite run success

1464 tests passing in 201 suites.

Report generated by 🧪jest coverage report action from 7bde6b3

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing 💯

@katspaugh
Copy link
Member

Tested, works correctly now ✅

@katspaugh katspaugh merged commit 69e4992 into dev Sep 10, 2024
16 checks passed
@katspaugh katspaugh deleted the fix/safe-apps-search branch September 10, 2024 07:48
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Safe apps search not considering category
2 participants