Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Fix failing regression tests #4144

Merged
merged 4 commits into from
Sep 9, 2024
Merged

Tests: Fix failing regression tests #4144

merged 4 commits into from
Sep 9, 2024

Conversation

mike10ca
Copy link
Contributor

@mike10ca mike10ca commented Sep 9, 2024

What it solves

How this PR fixes it

  • Fix failing regression tests

How to test it

  • Run Cypress tests and observe outcome

Copy link

github-actions bot commented Sep 9, 2024

Copy link

github-actions bot commented Sep 9, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Sep 9, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

github-actions bot commented Sep 9, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.39% 11787/15037
🔴 Branches 58.96% 3008/5102
🟡 Functions 65.94% 1880/2851
🟡 Lines 79.79% 10633/13327
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / sentry.ts
46.67% (-20% 🔻)
0% (-11.11% 🔻)
0% (-100% 🔻)
46.15% (-23.08% 🔻)

Test suite run success

1464 tests passing in 201 suites.

Report generated by 🧪jest coverage report action from 2eb5d3d

@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
@katspaugh katspaugh reopened this Sep 9, 2024
@safe-global safe-global unlocked this conversation Sep 9, 2024
@@ -23,7 +23,8 @@ describe('[SMOKE] Swaps token tests', () => {
})

// TODO: Added to prod
it(
// TODO: Bug reported, skiping until fixed
it.skip(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can now restore this test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@francovenica francovenica self-requested a review September 9, 2024 12:00
@mike10ca mike10ca merged commit b04d5ed into dev Sep 9, 2024
16 checks passed
@mike10ca mike10ca deleted the fix-regress-tests branch September 9, 2024 12:21
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants