Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: put execute button to be full width on mobile display #4143

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

clovisdasilvaneto
Copy link
Contributor

@clovisdasilvaneto clovisdasilvaneto commented Sep 9, 2024

What it solves

Resolves #
#4142

How this PR fixes it

It adds correct sizes for the MUI screen variations (sm, xs, md, lg and xl)

How to test it

  1. Go to a safe you own 1/1
  2. Create a tx and go to the "Confirm transaction" modal screen

Screenshots

Before

Screenshot 2024-09-09 at 11 00 22

After

Screenshot 2024-09-09 at 10 56 45

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@clovisdasilvaneto clovisdasilvaneto linked an issue Sep 9, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Sep 9, 2024

Copy link

github-actions bot commented Sep 9, 2024


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copy link

github-actions bot commented Sep 9, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Sep 9, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 945.27 KB (🟡 +1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link

github-actions bot commented Sep 9, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.37% 11784/15037
🔴 Branches 58.94% 3007/5102
🟡 Functions 65.91% 1879/2851
🟡 Lines 79.76% 10630/13327

Test suite run success

1464 tests passing in 201 suites.

Report generated by 🧪jest coverage report action from d4a1a92

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested on different resolutions. ✅

Screenshot 2024-09-09 at 11 24 38

@katspaugh katspaugh merged commit 426b63a into dev Sep 9, 2024
15 of 16 checks passed
@katspaugh katspaugh deleted the fix/execute-mobile-button branch September 9, 2024 10:38
Copy link

gitpoap-bot bot commented Sep 9, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Safe Contributor:

GitPOAP: 2024 Safe Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Execute button looks broken in the tx modal in mobile UI
2 participants