Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: upgrade protocol-kit #4118

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Chore: upgrade protocol-kit #4118

merged 2 commits into from
Aug 27, 2024

Conversation

katspaugh
Copy link
Member

What it solves

An upgrade of the protocol-kit that has static network enabled for the JSON RPC provider to reduce the number of RPC calls.

@katspaugh katspaugh requested a review from schmanu August 27, 2024 14:36
Copy link

github-actions bot commented Aug 27, 2024

Copy link

github-actions bot commented Aug 27, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Aug 27, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.54% (-0.02% 🔻)
11740/14947
🔴 Branches
59.1% (-0.02% 🔻)
2997/5071
🟡 Functions
66.01% (-0.04% 🔻)
1876/2842
🟡 Lines
79.93% (-0.02% 🔻)
10587/13245
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / sentry.ts
46.67% (-20% 🔻)
0% (-11.11% 🔻)
0% (-100% 🔻)
46.15% (-23.08% 🔻)

Test suite run success

1458 tests passing in 201 suites.

Report generated by 🧪jest coverage report action from d526315

@katspaugh katspaugh marked this pull request as draft August 27, 2024 14:46
@katspaugh
Copy link
Member Author

Looks like the passkeys support has some breaking changes. Need to adjust our code.

Copy link

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 944.91 KB (🟡 +11.39 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Six Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/apps 50.18 KB (🟡 +1.61 KB) 995.09 KB
/apps/custom 41.8 KB (🟡 +1.61 KB) 986.71 KB
/apps/open 53.34 KB (🟡 +1.61 KB) 998.25 KB
/home 60.23 KB (🟡 +1.61 KB) 1005.14 KB
/settings/notifications 27.62 KB (🟡 +1 B) 972.53 KB
/settings/safe-apps 25.55 KB (🟡 +1.61 KB) 970.46 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@katspaugh katspaugh marked this pull request as ready for review August 27, 2024 15:05
@katspaugh katspaugh merged commit 6c89ee2 into dev Aug 27, 2024
15 of 16 checks passed
@katspaugh katspaugh deleted the protocol-kit branch August 27, 2024 17:58
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant