feat: blockaid integration #4029

schmanu · 2024-08-02T08:30:31Z

What it solves

Integrates the BlockAid API for security scanning.

How this PR fixes it

exchanges redefine for blockaid
redesigns warning component

How to test it

Do any tx or message signing

TODO

Better error handling
Figure out how we handle the prod API key
(optional): Pass Safe App / Wallet Connect URI as domain field

Screenshots

Checklist

I've tested the branch on mobile 📱
I've documented how it affects the analytics (if at all) 📊
I've written a unit/e2e test for it (if applicable) 🧑‍💻

- exchanges redefine for blockaid - redesigns warning component

github-actions · 2024-08-02T08:30:45Z

Branch preview

✅ Deploy successful!

Website:
https://feat_switch_security_provider--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook:
https://feat_switch_security_provider--walletweb.review.5afe.dev/storybook/

notion-workspace · 2024-08-02T08:31:13Z

Integrate Blockaid Scans

github-actions · 2024-08-02T08:31:35Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

github-actions · 2024-08-02T08:34:13Z

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`949.6 KB` (🟡 +19 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load
`/balances`	`30.64 KB` (🟡 +1 B)	980.24 KB

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

github-actions · 2024-08-02T08:36:35Z

Coverage report

St.^❔	Category	Percentage	Covered / Total
🟡	Statements	78.45% (-0.05% 🔻)	11859/15116
🔴	Branches	59.02% (-0.08% 🔻)	3042/5154
🟡	Functions	65.82% (-0.13% 🔻)	1885/2864
🟡	Lines	79.89% (-0.05% 🔻)	10701/13394

Show new covered files 🐣

St.^❔	File	Statements	Branches	Functions	Lines
🟢	`...` / useBlockaid.ts	100%	100%	100%	100%
🟢	`...` / index.ts	83.78%	41.18%	50%	83.78%
🔴	`...` / index.tsx	50.85%	3.45%	8.33%	52.94%
🟢	`...` / utils.ts	85.71%	100%	100%	100%
🟡	`...` / BlockaidHint.tsx	50%	100%	0%	66.67%
🟡	`...` / BlockaidBalanceChange.tsx	66.67%	4.76%	10%	65.85%

Show files with reduced coverage 🔻

St.^❔	File	Statements	Branches	Functions	Lines
🟢	`...` / config.tsx	86.96% (-0.54% 🔻)	100%	100%	100%
🟢	`...` / SecurityWarnings.tsx	66.67% (-8.33% 🔻)	100%	100%	100%

Test suite run success

1483 tests passing in 203 suites.

Report generated by 🧪jest coverage report action from cc7f22b

…rovider

github-actions · 2024-08-19T08:05:16Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

…rovider

github-actions · 2024-08-28T12:14:08Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

katspaugh · 2024-08-29T09:35:43Z

Some unit tests are failing but we can already send this to QA.

schmanu · 2024-08-29T09:37:35Z

Some unit tests are failing but we can already send this to QA.

They are not really failing. The job just fails when trying to publish results -.- but the test cases all pass.

katspaugh · 2024-08-29T10:01:16Z

.env.example

-# Redefine
-NEXT_PUBLIC_REDEFINE_API=
+# Blockaid
+NEXT_PUBLIC_BLOCKAID_CLIENT_ID


This var has to be added to the build.yml action too.

francovenica · 2024-09-04T03:44:59Z

I tried using the tool provided and tried to trigger some transactions, but all of them would show this message (bening and malicious ones the same)

It seems that the validation of the tx is failing, thus not being able to tell you if the tx is malicious or not.

I got the message to show up once when the SDK initialialize correctly, but I'd assume this is a mistake because the message seems to be there by default as soon as the tx pop's up and then it should be updated depending on if the tx is malicious or not, so I think in this particular case the message simply didn't update

Also I don't think the message should be green if the tx is malicious

schmanu · 2024-09-06T08:46:13Z

@francovenica could you share what those transactions did?
I cannot reproduce any of those cases :/

francovenica · 2024-09-06T17:53:43Z

I used the tool you shsared with Lily https://examples.blockaid.io/. Every malicious tx would show what I reported in my comment

schmanu · 2024-09-09T07:13:33Z

I used the tool you shsared with Lily https://examples.blockaid.io/. Every malicious tx would show what I reported in my comment

@francovenica And the last case where it says "Transaction is malicious" in the success color? Do you remember how that happened?

katspaugh · 2024-09-09T07:19:30Z

Blocked on BlockAid's side due to some errors (we reached out for help).

github-actions · 2024-09-09T11:27:50Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

francovenica · 2024-09-10T09:23:27Z

@schmanu I never got to see it twice. There was that SDK error that happened once and the green message just popped.
I tested several times after and it seems that there is a split second that the green text shows up, like if it is loaded by default, and then is covered by the "could not check" warning message

liliya-soroka · 2024-09-11T11:59:52Z

approved internally together with @kirkkonen

…rovider

github-actions · 2024-09-11T12:07:18Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

feat: blockaid integration

8df97d6

- exchanges redefine for blockaid - redesigns warning component

schmanu added 5 commits August 9, 2024 10:10

feat: better error handling

b3400a9

fix: adjust design for errors

34766c9

feat: add powered by footer

ae4bfac

feat: add more chains, code cleanup

5c7c35d

Merge remote-tracking branch 'origin/dev' into feat/switch-security-p…

dac1789

…rovider

schmanu requested a review from katspaugh August 19, 2024 08:07

schmanu added 2 commits August 28, 2024 14:07

fix: change URL and auth header

cb5594e

Merge remote-tracking branch 'origin/dev' into feat/switch-security-p…

8007d78

…rovider

katspaugh approved these changes Aug 29, 2024

View reviewed changes

katspaugh reviewed Aug 29, 2024

View reviewed changes

fix: update .env variable in build.yml

85f2a8d

katspaugh added the blocked label Sep 9, 2024

schmanu added 2 commits September 9, 2024 10:14

fix: throw error if validation is missing

f115f9c

fix: loading state of blockaid block

3377a19

schmanu removed the blocked label Sep 9, 2024

Merge remote-tracking branch 'origin/dev' into feat/switch-security-p…

303d8cd

…rovider

tests: adjust mock

cc7f22b

katspaugh merged commit ab3871b into dev Sep 11, 2024
15 of 16 checks passed

katspaugh deleted the feat/switch-security-provider branch September 11, 2024 14:59

github-actions bot locked and limited conversation to collaborators Sep 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: blockaid integration #4029

feat: blockaid integration #4029

schmanu commented Aug 2, 2024 •

edited by katspaugh

Loading

github-actions bot commented Aug 2, 2024 •

edited

Loading

notion-workspace bot commented Aug 2, 2024

github-actions bot commented Aug 2, 2024

github-actions bot commented Aug 2, 2024 •

edited

Loading

github-actions bot commented Aug 2, 2024 •

edited

Loading

github-actions bot commented Aug 19, 2024

github-actions bot commented Aug 28, 2024 •

edited

Loading

katspaugh commented Aug 29, 2024

schmanu commented Aug 29, 2024

katspaugh Aug 29, 2024

francovenica commented Sep 4, 2024 •

edited

Loading

schmanu commented Sep 6, 2024

francovenica commented Sep 6, 2024

schmanu commented Sep 9, 2024

katspaugh commented Sep 9, 2024

github-actions bot commented Sep 9, 2024

francovenica commented Sep 10, 2024

liliya-soroka commented Sep 11, 2024

github-actions bot commented Sep 11, 2024 •

edited

Loading

feat: blockaid integration #4029

feat: blockaid integration #4029

Conversation

schmanu commented Aug 2, 2024 • edited by katspaugh Loading

What it solves

How this PR fixes it

How to test it

TODO

Screenshots

Checklist

github-actions bot commented Aug 2, 2024 • edited Loading

Branch preview

notion-workspace bot commented Aug 2, 2024

github-actions bot commented Aug 2, 2024

ESLint Summary View Full Report

github-actions bot commented Aug 2, 2024 • edited Loading

📦 Next.js Bundle Analysis for safe-wallet-web

⚠️ Global Bundle Size Increased

One Page Changed Size

github-actions bot commented Aug 2, 2024 • edited Loading

Coverage report

Test suite run success

github-actions bot commented Aug 19, 2024

ESLint Summary View Full Report

github-actions bot commented Aug 28, 2024 • edited Loading

ESLint Summary View Full Report

katspaugh commented Aug 29, 2024

schmanu commented Aug 29, 2024

katspaugh Aug 29, 2024

Choose a reason for hiding this comment

francovenica commented Sep 4, 2024 • edited Loading

schmanu commented Sep 6, 2024

francovenica commented Sep 6, 2024

schmanu commented Sep 9, 2024

katspaugh commented Sep 9, 2024

github-actions bot commented Sep 9, 2024

ESLint Summary View Full Report

francovenica commented Sep 10, 2024

liliya-soroka commented Sep 11, 2024

github-actions bot commented Sep 11, 2024 • edited Loading

ESLint Summary View Full Report

schmanu commented Aug 2, 2024 •

edited by katspaugh

Loading

github-actions bot commented Aug 2, 2024 •

edited

Loading

github-actions bot commented Aug 2, 2024 •

edited

Loading

github-actions bot commented Aug 2, 2024 •

edited

Loading

github-actions bot commented Aug 28, 2024 •

edited

Loading

francovenica commented Sep 4, 2024 •

edited

Loading

github-actions bot commented Sep 11, 2024 •

edited

Loading