Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: account list address and balance are misaligned for smaller screens #4007

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

jmealy
Copy link
Contributor

@jmealy jmealy commented Jul 29, 2024

What it solves

Resolves #3970

How this PR fixes it

  • Stack the balance underneath the address for smaller screens

How to test it

  • open the safe list in the sidebar or the accounts page
  • resize the screen to be < 500px
  • See that the address and balance are displayed on top of one another.

Screenshots

image

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Jul 29, 2024

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.01 MB (🟡 +3 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 79.04% 11714/14821
🔴 Branches 58.8% 2911/4951
🟡 Functions 66.13% 1876/2837
🟢 Lines 80.44% 10558/13126

Test suite run success

1446 tests passing in 200 suites.

Report generated by 🧪jest coverage report action from 10f9472

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@katspaugh
Copy link
Member

Tested, looks good on mobile 👍

@katspaugh katspaugh merged commit d03838f into dev Jul 29, 2024
14 checks passed
@katspaugh katspaugh deleted the align-account-list branch July 29, 2024 16:56
@github-actions github-actions bot locked and limited conversation to collaborators Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Account list item contents are misaligned for smaller screens
2 participants