fix: Harden condition for loading spending limits

[usame-algan]

What it solves

Part of #2414

How this PR fixes it

• getSpendingLimits was called twice because the condition only checked for the existence of tokenInfoFromBalances but the initial value is an empty array so it should check the length of the array instead

How to test it

1. Open a Safe with a spending limit
2. It should still be visible under settings and when trying to create a transaction

Checklist

• I've tested the branch on mobile 📱
• I've documented how it affects the analytics (if at all) 📊
• I've written a unit/e2e test for it (if applicable) 🧑‍💻

[github-actions]

Branch preview

✅ Deploy successful!

Website:
https://fix_spending_limit_requests--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook:
https://fix_spending_limit_requests--walletweb.review.5afe.dev/storybook/

[usame-algan]

I wonder what is the expected behaviour in case there are no tokens in a safe? Assuming tokenInfoFromBalances would always return an empty array we would not display the spending limits to the user anymore.

[github-actions]

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

• Result: ✅ success
• Annotations: 0 total

---

^{Report generated by eslint-plus-action}

[github-actions]

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
global	1013.08 KB (🟡 +3 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

[compojoom]

I think that this should get our RPC count significantly down as due to this we were doing the queries twice.

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟡	Statements	79.06%	11673/14764
🔴	Branches	58.87%	2894/4916
🟡	Functions	66.09%	1867/2825
🟢	Lines	80.45%	10522/13079

Test suite run success

1442 tests passing in 199 suites.

Report generated by 🧪jest coverage report action from b93849e

[schmanu]

Assuming tokenInfoFromBalances would always return an empty array we would not display the spending limits to the user anymore.

@usame-algan I think the tokenInfoFromBalances always contains an entry for the native token once fetched from the CGW - even if it is 0. I just setup Spending Limits on a Safe without any balances and they get displayed correctly in the settings.

[katspaugh]

@schmanu I think that's fine because the purpose of that check is to verify that the balances are fetched from CGW.
This could probably be more cleanly achieved via const { balances, loading } = useBalances().

Looks like this hook is also re-run each time balances are polled...

[francovenica]

Spending limit looks fine

Creation, edition, removal.
With Native and ERC 20 token.
Use of the spending limt with the user
Use all the tokens allowed
Check the refresh of the allowance

LGTM