Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add correct contents to section 18 of terms page #3976

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Conversation

jmealy
Copy link
Contributor

@jmealy jmealy commented Jul 22, 2024

What it solves

  • Section 18 had repeated content.
  • Some of the references to other sections were incorrect
    Requested by legal

It also updates the flag for if the user has accepted the terms and conditions, so it should show to all users again.

Copy link

github-actions bot commented Jul 22, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@jmealy jmealy requested a review from katspaugh July 22, 2024 10:35
Copy link

github-actions bot commented Jul 22, 2024

Copy link

github-actions bot commented Jul 22, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/terms 11.24 KB (🟢 -359 B) 1 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Jul 22, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 79.06% 11673/14764
🔴 Branches 58.87% 2894/4916
🟡 Functions 66.09% 1867/2825
🟢 Lines 80.45% 10522/13079

Test suite run success

1442 tests passing in 199 suites.

Report generated by 🧪jest coverage report action from 2de2aa5

Copy link

github-actions bot commented Jul 23, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@jmealy jmealy merged commit 8e0c8e9 into dev Jul 24, 2024
14 checks passed
@jmealy jmealy deleted the fix-terms-ref branch July 24, 2024 07:09
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2024
@francovenica
Copy link
Contributor

Ticket was merged but I was asked to take a look.

Text changes Looks good to me
Also since is merged in dev I was able to check that the pop up to accept the terms and conditions shows again even after being dismissed before

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants