Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: fix tx deletion #3942

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Tests: fix tx deletion #3942

merged 1 commit into from
Jul 12, 2024

Conversation

katspaugh
Copy link
Member

What it solves

This fixes the Private Key signer wallet in e2e tests, specifically transaction deletion.

JSON parse wasn't necessary.

@katspaugh katspaugh requested a review from mike10ca July 12, 2024 09:25
Copy link

github-actions bot commented Jul 12, 2024

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 1000.78 KB (-4 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
79.04% (+0.02% 🔼)
11617/14698
🔴 Branches 58.68% 2854/4864
🟡 Functions
66% (+0.04% 🔼)
1856/2812
🟢 Lines
80.43% (+0.02% 🔼)
10475/13024
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / useGasPrice.ts
95% (-1.25% 🔻)
80.95% (-2.38% 🔻)
100%
94.81% (-1.3% 🔻)

Test suite run success

1433 tests passing in 198 suites.

Report generated by 🧪jest coverage report action from f48d94c

@katspaugh katspaugh merged commit 1d53f15 into dev Jul 12, 2024
14 checks passed
@katspaugh katspaugh deleted the fix-e2e branch July 12, 2024 13:52
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2024
@mike10ca
Copy link
Contributor

@katspaugh , this does not seem to work. I tried to delete a tx from the queue and got the error. See screenshot.
tx

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants