Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: prompt -> confirm #3939

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Fix: prompt -> confirm #3939

merged 2 commits into from
Jul 12, 2024

Conversation

katspaugh
Copy link
Member

@katspaugh katspaugh commented Jul 12, 2024

What it solves

We were showing the wrong type of the native confirmation popup.

image (5)

Copy link

github-actions bot commented Jul 12, 2024

Copy link

github-actions bot commented Jul 12, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Jul 12, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 1000.78 KB (-3 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link

github-actions bot commented Jul 12, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 79.01% 11614/14699
🔴 Branches 58.66% 2853/4864
🟡 Functions 65.97% 1855/2812
🟢 Lines 80.4% 10472/13025

Test suite run success

1433 tests passing in 198 suites.

Report generated by 🧪jest coverage report action from e9dd317

@katspaugh katspaugh added this to the 1.39.2 milestone Jul 12, 2024
@liliya-soroka
Copy link
Member

could I get more details , because I am not sure where and what to test from the description?

@katspaugh
Copy link
Member Author

@liliya-soroka this is a fix for the bug you mentioned here: https://5afe.slack.com/archives/C03DAGWJCR5/p1720687961207999

When a dapp connected over WalletConnect wants to switch the chain.

@liliya-soroka
Copy link
Member

Verified
image

@katspaugh katspaugh merged commit cdec625 into dev Jul 12, 2024
14 checks passed
@katspaugh katspaugh deleted the prompt branch July 12, 2024 11:37
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants