-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: prompt -> confirm #3939
Fix: prompt -> confirm #3939
Conversation
Branch preview✅ Deploy successful! Website: Storybook: |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! |
Coverage report
Test suite run success1433 tests passing in 198 suites. Report generated by 🧪jest coverage report action from e9dd317 |
could I get more details , because I am not sure where and what to test from the description? |
@liliya-soroka this is a fix for the bug you mentioned here: https://5afe.slack.com/archives/C03DAGWJCR5/p1720687961207999 When a dapp connected over WalletConnect wants to switch the chain. |
What it solves
We were showing the wrong type of the native confirmation popup.