Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: uncaught error in GeoblockingProvider #3938

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Fix: uncaught error in GeoblockingProvider #3938

merged 1 commit into from
Jul 15, 2024

Conversation

katspaugh
Copy link
Member

What it solves

There are uncaught errors logged to Sentry coming from GeoblockingProvider.

I've refactored the hook to use useAsync that catches async errors.

@katspaugh katspaugh requested a review from compojoom July 12, 2024 07:39
Copy link

github-actions bot commented Jul 12, 2024

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
79.04% (+0.03% 🔼)
11616/14696
🔴 Branches
58.67% (+0.01% 🔼)
2853/4863
🟡 Functions
66.01% (+0.05% 🔼)
1855/2810
🟢 Lines
80.43% (+0.03% 🔼)
10474/13022

Test suite run success

1433 tests passing in 198 suites.

Report generated by 🧪jest coverage report action from ef85a98

@katspaugh katspaugh requested a review from schmanu July 12, 2024 08:17
@katspaugh katspaugh added this to the 1.39.2 milestone Jul 12, 2024
@liliya-soroka
Copy link
Member

@compojoom , could you help to test , please?

@liliya-soroka
Copy link
Member

Returned back - it's possible to use swap and the swap feature is not hidden as on prod

@katspaugh
Copy link
Member Author

Geoblocking is only configured in prod.

@katspaugh katspaugh removed this from the 1.39.2 milestone Jul 12, 2024
@katspaugh katspaugh merged commit b120b5c into dev Jul 15, 2024
14 checks passed
@katspaugh katspaugh deleted the catch branch July 15, 2024 08:55
@github-actions github-actions bot locked and limited conversation to collaborators Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants