Fix: correct filtering of history for txs marked trusted and imitation [SW-100] #3907
Conversation
Branch preview✅ Deploy successful! Storybook: |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success1436 tests passing in 198 suites. Report generated by 🧪jest coverage report action from f8e07b1 |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
1 MB (🟡 +10 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Two Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/transactions |
73.43 KB (🟡 +1 B) |
1.08 MB |
/transactions/history |
73.4 KB (🟡 +1 B) |
1.08 MB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
| const [data, error, loading] = useAsync<TransactionListPage>( | ||
| () => { | ||
| if (!safeLoaded) return | ||
| if (!safe.deployed) return Promise.resolve({ results: [] }) | ||
|
|
||
| return getTxHistory(chainId, safeAddress, hasDefaultTokenlist && showOnlyTrustedTransactions) | ||
| return getTxHistory(chainId, safeAddress, hasDefaultTokenlist && hideSuspiciousTransactions) |
There was a problem hiding this comment.
| return getTxHistory(chainId, safeAddress, hasDefaultTokenlist && hideSuspiciousTransactions) | |
| return getTxHistory(chainId, safeAddress, hideSuspiciousTransactions) |
The default token list is not necessary for the new imitation detection.
src/hooks/useTxHistory.ts
Outdated
| const hasDefaultTokenlist = useHasFeature(FEATURES.DEFAULT_TOKENLIST) | ||
| const onlyTrusted = (hasDefaultTokenlist && showOnlyTrustedTransactions) || false | ||
| const hideSuspicious = (hasDefaultTokenlist && hideSuspiciousTransactions) || false |
There was a problem hiding this comment.
| const hideSuspicious = (hasDefaultTokenlist && hideSuspiciousTransactions) || false | |
| const hideSuspicious = (hideSuspiciousTransactions) || false |
Same here
src/services/transactions/index.ts
Outdated
| @@ -18,13 +18,15 @@ export const getTxDetails = memoize( | |||
| (id: string, chainId: string) => `${chainId}-${id}`, | |||
| ) | |||
|
|
|||
| export const getTxHistory = (chainId: string, safeAddress: string, trusted = false, pageUrl?: string) => { | |||
| export const getTxHistory = (chainId: string, safeAddress: string, hideSuspicious = false, pageUrl?: string) => { | |||
There was a problem hiding this comment.
We should maybe have two flags for trusted and imitation that we pass here.
The trusted filtering requires token lists to be available. But imitations don't.
There was a problem hiding this comment.
Created separate flags here and also in fetchFilteredTxHistory
ESLint Summary View Full Report
Report generated by eslint-plus-action |
jmealy
changed the title
ESLint Summary View Full Report
Report generated by eslint-plus-action |
|
I noticed an issue with the filtering, but it is pre-existing so I created a separate ticket for it: #4005 |
|
Verified |
What it solves
If there is a transaction marked with
trusted: trueandimitation: true, then it does not get filtered with thehide malicioustoggle in the transaction history page.How this PR fixes it
imitationquery param for the/historyendpoint, based on the value of thehide malicioustoggle button on the transaction history page.hide malicioustoggle in user settings to reflect the new name in the UI, and differentiate from thetrustedflag on transactions.