-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Make transaction details scrollable during creation #3899
Conversation
Branch preview✅ Deploy successful! Storybook: |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
Page | Size (compressed) |
---|---|
global |
1000.78 KB (🟡 +3 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Coverage report
Test suite run success1426 tests passing in 197 suites. Report generated by 🧪jest coverage report action from 553233e |
I had the same issue so I used curve via WC instead of as a safe app. |
What it solves
Resolves #2682
How this PR fixes it
overflow-x: auto
property toDataRow
componentHow to test it
TxDataRow
/DataRow
component is also used for Swaps, TxSummary, MsgDetails, RecoveryDetails. Make sure these places still work as expectedScreenshots
Screen.Recording.2024-07-03.at.15.00.27.mov
Checklist