Feat: copy addresses on click #2838
Conversation
Branch preview✅ Deploy successful! |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
1.4 MB (🟡 +581 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Seven Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/apps |
34.59 KB (🟢 -5 B) |
1.43 MB |
/apps/custom |
27.12 KB (🟢 -5 B) |
1.42 MB |
/home |
23.61 KB (🟢 -6 B) |
1.42 MB |
/new-safe/create |
11.83 KB (🟡 +2 B) |
1.41 MB |
/new-safe/load |
7.3 KB (🟡 +12 B) |
1.4 MB |
/settings/appearance |
8.19 KB (🟢 -349 B) |
1.4 MB |
/share/safe-app |
9.43 KB (🟢 -6 B) |
1.41 MB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
Coverage report
Show new covered files 🐣
Test suite run success1096 tests passing in 153 suites. Report generated by 🧪jest coverage report action from 124c0c2 |
|
Is fine regarding the copy, but I have some concerns regarding tight spaces For the top right corner, when you click the button to change wallets, a good amount of the area is the address, so the users will have to press the arrow or they will just copy the address instead of opening the dropdown: In mobile we have the sidebar with safes, where again big part of the area is the address, so is gonna be harder for them to select a safe. the user will have to touch the icon or the corners of the regtangle to change to that safe: |
|
Good point, I’ll disable it in those instances. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
|
It is hard to select an address from the address book , because of the copy function for the enter address fields. |
|
Definitely, @liliya-soroka, will do! |
What it solves
In all places where we display Ethereum addresses, make them clickable to copy to the clipboard.
This is congruent with how other dapps do it, and makes it much easier for the user to copy addresses.