Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update illustration for new tx #2249

Merged
merged 1 commit into from
Jul 7, 2023
Merged

fix: Update illustration for new tx #2249

merged 1 commit into from
Jul 7, 2023

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Jul 7, 2023 •
edited
Loading

What it solves

Part of #2067

How this PR fixes it

  • Updates the illustration when creating a new transaction

How to test it

  1. Open a Safe
  2. Press New transaction
  3. Observe the new image
  4. Switch to dark/light mode
  5. Observe the image changing

Screenshots

Screenshot 2023-07-07 at 09 41 42 Screenshot 2023-07-07 at 09 41 50

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@usame-algan usame-algan requested a review from iamacook July 7, 2023 07:41
@github-actions
Copy link

github-actions bot commented Jul 7, 2023 •
edited
Loading

Branch preview

✅ Deploy successful!

https://new_tx_illu--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@usame-algan usame-algan requested review from schmanu and removed request for iamacook July 7, 2023 07:57
schmanu
schmanu approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@schmanu schmanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💎

@usame-algan usame-algan merged commit d2b70b3 into epic-tx-flow Jul 7, 2023
6 of 7 checks passed
@usame-algan usame-algan deleted the new-tx-illu branch July 7, 2023 09:00
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmanu schmanu schmanu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@usame-algan @schmanu