Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Apply input styles to all input fields #2231

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Conversation

usame-algan
Copy link
Member

What it solves

Part of #2067

How this PR fixes it

  • Extracts inputs styles into a common css file inputs.module.css
  • Applies the new input styles (66px height, border-color) to all input fields

How to test it

  1. Open a Safe
  2. Create/Add a safe and observe all input fields have the same border color and height
  3. Do the same for all other flows
  4. Check the transaction history filter

Screenshots

Screenshot 2023-07-05 at 11 45 27 Screenshot 2023-07-05 at 11 45 58

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@usame-algan usame-algan requested a review from iamacook July 5, 2023 09:46
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Branch preview

✅ Deploy successful!

https://input_css--walletweb.review-wallet-web.5afe.dev

@usame-algan
Copy link
Member Author

I suggest we do this in the theme file once we copy it over to this repository instead of having a custom css that we need to remember to always include.

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@usame-algan usame-algan merged commit 55cdf74 into epic-tx-flow Jul 5, 2023
7 checks passed
@usame-algan usame-algan deleted the input-css branch July 5, 2023 11:54
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants