[TX flow] feat: replace owner #2151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview⏳ Deploying a preview site... |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
iamacook
requested changes
Jun 22, 2023
| @@ -26,7 +26,7 @@ const NameInput = ({ | |||
| error={Boolean(fieldError)} | |||
| fullWidth | |||
| required={required} | |||
| sx={{ '& .MuiInputBase-input': { p: 3, px: 2 } }} | |||
| sx={{ mt: 1, '& .MuiInputBase-input': { py: '22px', px: 2 } }} | |||
There was a problem hiding this comment.
Nit: let's move this to the CSS module.
|
|
||
| return ( | ||
| <TxCard> | ||
| <FormProvider {...formMethods}> | ||
| <form onSubmit={onFormSubmit} className={commonCss.form}> | ||
| <Box mb={1}> | ||
| <Typography variant="body2" mb={1}> |
There was a problem hiding this comment.
The Typography element should also be conditional.
| @@ -32,7 +33,7 @@ const ReplaceOwnerFlow = ({ address }: { address: string }) => { | |||
| ] | |||
|
|
|||
| return ( | |||
| <TxLayout title="Replace owner" step={step} onBack={prevStep}> | |||
| <TxLayout title="New transaction" subtitle="Replace owner" icon={SaveAddressIcon} step={step} onBack={prevStep}> | |||
There was a problem hiding this comment.
Suggested change
| <TxLayout title="New transaction" subtitle="Replace owner" icon={SaveAddressIcon} step={step} onBack={prevStep}> | |
| <TxLayout title={step === 0 ? "New transaction" : "Confirm transaction"} subtitle="Replace owner" icon={SaveAddressIcon} step={step} onBack={prevStep}> |
|
Belated design feedback for @liliiaorlenko, this is really hard to parse. It's unclear which label belongs to which address. And why is there also a third address in grey? I would expect it to look more like:
|
3 tasks
iamacook
approved these changes
Jun 22, 2023
Co-authored-by: Aaron Cook <aaron@safe.global>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Implements "Replace Owner" designs for the new tx flow
How to test it
Navigate the "Replace Owner" flow
Screenshots
Checklist