Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TX flow] style: offchain messages info boxes styles #2134

Merged
merged 6 commits into from
Jun 20, 2023

Conversation

DiogoSoaress
Copy link
Member

What it solves

Styles offchain messages info boxes styles as per designs

How to test it

Trigger a modal to collect signatures in a m/N Safe

Screenshots

Screenshot 2023-06-20 at 13 33 27

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@github-actions
Copy link

github-actions bot commented Jun 20, 2023

Branch preview

✅ Deploy successful!

https://tx_flow_offchain_msg_styles--walletweb.review-wallet-web.5afe.dev

@DiogoSoaress DiogoSoaress self-assigned this Jun 20, 2023
@github-actions
Copy link

github-actions bot commented Jun 20, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@@ -79,7 +79,7 @@ export const MsgSigners = ({
</ListItem>
)}
<ListItem>
<ListItemIcon>
<ListItemIcon sx={{ backgroundColor: backgroundColor }}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<ListItemIcon sx={{ backgroundColor: backgroundColor }}>
<ListItemIcon sx={{ backgroundColor }}>

@katspaugh katspaugh merged commit 23bbb96 into epic-tx-flow Jun 20, 2023
@katspaugh katspaugh deleted the tx-flow-offchain-msg-styles branch June 20, 2023 14:38
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants