Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show messages tab if chain supports EIP-1271 #2129

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Conversation

iamacook
Copy link
Member

What it solves

Resolves #2101

How this PR fixes it

The messages tab is now always shown if a chain supports EIP-1271, no longer taking into account if signed messages exist.

How to test it

  1. Open a Safe on a chain that supports EIP-1271 with no signed messages and observe the tab present.
  2. Switch to a Safe on a chain that doesn't support EIP-1271 and observe no tab present.

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook self-assigned this Jun 20, 2023
@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@iamacook iamacook merged commit e492a32 into dev Jun 20, 2023
@iamacook iamacook deleted the show-messages branch June 20, 2023 07:53
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Messages Tab only appears after reload
3 participants