Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow non-owners with spending limit to execute transaction #2121

Merged
merged 1 commit into from
Jun 24, 2023

Conversation

elgatovital
Copy link
Contributor

@elgatovital elgatovital commented Jun 19, 2023

What it solves

Allows non-owners with spending limit to execute transaction

Resolves #2073

How to test it

  • Create safe 2of2
  • add owners Owner1Addr and Owner2Addr
  • add spending limit of 1 ETH for NonOwnerAddr
  • Create send 2 ETH transaction
  • sign with Owner1Addr and Owner2Addr but do not execute
  • Attempt to execute transaction with NonOwnerAddr

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@elgatovital elgatovital self-assigned this Jun 19, 2023
@github-actions
Copy link

github-actions bot commented Jun 19, 2023

Branch preview

✅ Deploy successful!

https://issue_2073--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Jun 19, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions
Copy link

github-actions bot commented Jun 19, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@elgatovital
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@elgatovital
Copy link
Contributor Author

recheck

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you Vitaly!

@usame-algan
Copy link
Member

I suggest we also write a few more unit tests for this component to cover the new case.

@elgatovital elgatovital merged commit ea5510f into dev Jun 24, 2023
@elgatovital elgatovital deleted the issue-2073 branch June 24, 2023 08:19
@gitpoap-bot
Copy link

gitpoap-bot bot commented Jun 24, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 Safe Contributor:

GitPOAP: 2023 Safe Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-owner spending limit address cannot execute signed transactions
3 participants