Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: save entire data structure on submission #2083

Merged
merged 4 commits into from
Jun 12, 2023

Conversation

iamacook
Copy link
Member

What it solves

This updates the nextStep function to require the entire data structure to be set on submission.

Other small changes

  • Only renders current step
  • Adds back button (yet to be styled)
  • Closes modal when signing

How to test it

Open the transaction creation flow and click next, observing the data present in the second step. Clicking back should also retain the values on the first step.

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@github-actions
Copy link

github-actions bot commented Jun 12, 2023

Branch preview

✅ Deploy successful!

https://refactor_stepper--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@iamacook iamacook merged commit 1b63a8f into epic-tx-flow Jun 12, 2023
@iamacook iamacook deleted the refactor-stepper branch June 12, 2023 15:30
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants