Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not rerender approval editor in confirmation modal #2004

Merged
merged 1 commit into from
May 24, 2023

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented May 19, 2023

What it solves

Avoids rerenders of approval editor, when the queue gets polled

Resolves #2003

How this PR fixes it

Memoize prop for approval editor

How to test it

  1. Queue a transaction containing approval(s)
  2. Wait ~10-15s
  3. Witness the approval editor rerendering

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@schmanu schmanu requested a review from DiogoSoaress May 19, 2023 12:07
@github-actions
Copy link

github-actions bot commented May 19, 2023

Branch preview

✅ Deploy successful!

https://fix_approval_editor_rerender--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@francovenica
Copy link
Contributor

Made a comment in the original issue that i wasn't able to reproduce the issue but I wasn't looking in the right place. I found it now, so I was able to reproduce it.

LGTM
I'll post how it looks before and I can confirm that now that flicker doesn't happen anymore with the fix
appEditFlikr

@schmanu schmanu merged commit cf0ec1f into dev May 24, 2023
@schmanu schmanu deleted the fix-approval-editor-rerender branch May 24, 2023 13:52
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ApprovalEditor rerenders too often in queue
4 participants