Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: general app settings in the footer #1999

Merged
merged 3 commits into from
May 24, 2023
Merged

Feat: general app settings in the footer #1999

merged 3 commits into from
May 24, 2023

Conversation

katspaugh
Copy link
Member

What it solves

Resolves #1994

How this PR fixes it

Makes the Settings page work for not Account-specific URLs.

How to test it

Case 1:

  • Open Welcome
  • Go to Settings via the footer

Case 2:

  • Open a Safe
  • Go to Safe settings via the sidebar menu

Case 3:

  • Check that the Cookie banner still works and looks like before

Screenshots

Screenshot 2023-05-17 at 12 48 59

@github-actions
Copy link

github-actions bot commented May 17, 2023

Branch preview

✅ Deploy successful!

https://settings--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented May 17, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@francovenica
Copy link
Contributor

Looks good. I would not noticed the change in the title of the page if I hadn't checked that last commits, good early catch.

I've checked that the settings opens fine from the welcome page or the settings page (the 2 places where you can see the footer)
Tested that the cookies policies still work fine in this new page. I like that the cookie banner that opens for first users closes automatically if you accept selection/accept all in this new preferences/settings page
The settings work fine (prefix, dark mode, data import/export, RPC change)

@katspaugh katspaugh merged commit 5135041 into dev May 24, 2023
@katspaugh katspaugh deleted the settings branch May 24, 2023 06:42
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No way to change settings on non-Safe-specific URLs like /welcome
3 participants