Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pending skeletons + indexing statuses #1755

Merged
merged 2 commits into from
Mar 10, 2023
Merged

fix: pending skeletons + indexing statuses #1755

merged 2 commits into from
Mar 10, 2023

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Mar 9, 2023

What it solves

Resolves (1) duplicate skeletons on queue and (2) hidden "Execute transaction" checkbox.

How this PR fixes it

  1. The pending transactions TxPage does no longer skeletons. There are two network requests on the page (for pending and queued transactions) which otherwise show their own skeletons.
  2. Transactions are no longer marked as pending if they are indexed. (This needs to be refactored). We did not previously encounter this bug as we weren't checking the presence of pending transactions.

How to test it

  1. Queue a transaction and switch back and forth between the History and Queue. Observe no duplicate skeleton above the queued transaction.
  2. Create and execute a transaction on a 1/n Safe. Create a new transaction and observe the "Execute transaction" checkbox on the review step.

Screenshots

skeleton

execution checkbox

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook requested a review from schmanu March 9, 2023 14:59
@iamacook iamacook self-assigned this Mar 9, 2023
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

Branch preview

✅ Deploy successful!

https://pending_skeleton--webcore.review-web-core.5afe.dev

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@francovenica
Copy link
Contributor

LGTM
The skeleton was removed
The execute now button shows now for tx 1/x. Checked tx rejection, replacement and safes 2/x for the last owner signature as well

Copy link
Member

@schmanu schmanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀

@iamacook iamacook merged commit f5d9fd5 into dev Mar 10, 2023
@iamacook iamacook deleted the pending-skeleton branch March 10, 2023 11:22
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants