Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only show safeTxGas when present #1753

Merged
merged 1 commit into from
Mar 9, 2023
Merged

fix: only show safeTxGas when present #1753

merged 1 commit into from
Mar 9, 2023

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Mar 9, 2023

What it solves

Resolves regression.

How this PR fixes it

The safeTxGas is only show if present, meaning that it won't display for 1.3.0 Safes.

How to test it

Create a transaction on a 1.3.0 Safe and observe that the safeTxGas is not shown in the advanced gas parameters.

Screenshots

image

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook self-assigned this Mar 9, 2023
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

Branch preview

✅ Deploy successful!

https://fix_safetxgas--webcore.review-web-core.5afe.dev

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@iamacook iamacook mentioned this pull request Mar 9, 2023
@iamacook iamacook merged commit ce897e3 into dev Mar 9, 2023
@iamacook iamacook deleted the fix-safetxgas branch March 9, 2023 11:57
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants