Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: revert regression in useSafeAppFromManifest #1733

Merged
merged 2 commits into from
Mar 3, 2023
Merged

Conversation

katspaugh
Copy link
Member

@katspaugh katspaugh commented Mar 3, 2023

What it solves

Reverts a change from #1674

How this PR fixes it

A regression was introduced in #1674 which prevented Safe Apps with an unreachable manifest.json from being loaded.

How to test it

Load the InsurAce app, it should load w/o problem, but on prod it won't.

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Branch preview

✅ Deploy successful!

https://fix_manifest--webcore.review-web-core.5afe.dev

@katspaugh katspaugh changed the base branch from dev to main March 3, 2023 14:05
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@JagoFigueroa
Copy link

JagoFigueroa commented Mar 3, 2023

Hola señores, I am comparing this PR with the PR for 1.5.1 release and I've noticed this case for xdai bridge app on mainnet (might be more cases like this one, still checking).

On this PR it won't connect to the safe automatically (making it not usable).

But on 1.5.1 release PR I see that the connection is established as expected.

Any ideas what could be the change?

@katspaugh
Copy link
Member Author

Should be good now. Looks like there’s a pretty fragile dependency on the timing of the router.

@JagoFigueroa
Copy link

Looks good to me. Thank you for the quick action!

@katspaugh
Copy link
Member Author

Thank you caballero!

@katspaugh katspaugh merged commit cdebd97 into main Mar 3, 2023
@katspaugh katspaugh deleted the fix-manifest branch March 3, 2023 17:13
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants