-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Display manual gasLimit in GasParams overview #1711
Conversation
Branch preview✅ Deploy successful! |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
@@ -34,6 +34,7 @@ const GasParams = ({ params, isExecution, isEIP1559, onEdit, gasLimitError }: Ga | |||
|
|||
const chain = useCurrentChain() | |||
const isLoading = !gasLimit || !maxFeePerGas | |||
const isError = gasLimitError && !gasLimit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we need gasLimitError
or could pass the loading flag instead and do const isError = !gasLimitLoading && !gasLimit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain a little bit what the root cause of the bug was and how you fixed it?
Changing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get it now, thanks!
Looks good. The value now reflects in the UI. |
What it solves
Resolves #1661
Changing the
gasLimit
is possible in any case but wasn't reflected in the UIHow this PR fixes it
gasLimit
in theGasParams
overview if it existsHow to test it
Analytics changes
Screenshots