Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: useSafeTokenAlocation unit test #1685

Merged
merged 1 commit into from
Feb 20, 2023
Merged

fix: useSafeTokenAlocation unit test #1685

merged 1 commit into from
Feb 20, 2023

Conversation

DiogoSoaress
Copy link
Member

What it solves

Unit tests are failing in the CI without related changes

How this PR fixes it

Mock fetch implementation in the failing test

How to test it

Run yarn test useSafeTokenAlocation

@github-actions
Copy link

github-actions bot commented Feb 20, 2023

Branch preview

✅ Deploy successful!

https://fix_flaky_unit_test--webcore.review-web-core.5afe.dev

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it was making an actual request? No bueno. Nice fix!

@DiogoSoaress DiogoSoaress merged commit a51a9f8 into dev Feb 20, 2023
@DiogoSoaress DiogoSoaress deleted the fix-flaky-unit-test branch February 20, 2023 13:10
@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants