Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spending limit validation #1681

Merged
merged 2 commits into from
Feb 17, 2023
Merged

fix: spending limit validation #1681

merged 2 commits into from
Feb 17, 2023

Conversation

iamacook
Copy link
Member

What it solves

Resolves #1677

How this PR fixes it

The multisig option no longer validates according to a spending limit. When changing the transaction type, the amount is now again validated as well.

How to test it

Create a transaction and select "Multisig Transaction" when a spending limit is set. Observe no validation error when entering an amount above the spending limit. Switching to a "Spending Limit Transaction" should validate and show an error.

Screenshots

spending limit

@github-actions
Copy link

github-actions bot commented Feb 17, 2023

Branch preview

✅ Deploy successful!

https://spending_limit_max_amount--webcore.review-web-core.5afe.dev

@github-actions
Copy link

github-actions bot commented Feb 17, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bug! Thanks for rectifying it.

Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@francovenica
Copy link
Contributor

Looks good to me

The limit now responds to the choice the user makes in the modal
The max button works fine depending on your choice
Changing your choice after the amout is set is being validated as well
I tried changing the spending limit, and even disabling the module. it works fine

@iamacook iamacook merged commit e12d77b into dev Feb 17, 2023
@iamacook iamacook deleted the spending-limit-max-amount branch February 17, 2023 15:49
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Owner with spending limit cannot spend more than the limit set even for multi-sig transactions
4 participants