Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove claiming app from dashboard #1680

Merged
merged 2 commits into from
Feb 17, 2023
Merged

Fix: remove claiming app from dashboard #1680

merged 2 commits into from
Feb 17, 2023

Conversation

katspaugh
Copy link
Member

What it solves

The dashboard has a whole section for governance, no need to push our app also in the lower Safe Apps section.

@github-actions
Copy link

github-actions bot commented Feb 16, 2023

Branch preview

✅ Deploy successful!

https://rm_app--webcore.review-web-core.5afe.dev

@github-actions
Copy link

github-actions bot commented Feb 16, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't even know that we always showed the claiming app on position 1 🤔 Makes sense to remove it!

@francovenica
Copy link
Contributor

I didn't even know that we always showed the claiming app on position 1 🤔 Makes sense to remove it!

yes, it was hardcoded to always be the 1st one, even before most used apps or bookmarked apps.

@francovenica
Copy link
Contributor

LGTM

The app is no longer the first one all the time
Also checked it behaved like a regular app regarding "most used" apps and bookmarked apps.

@katspaugh katspaugh merged commit 5616f26 into dev Feb 17, 2023
@katspaugh katspaugh deleted the rm-app branch February 17, 2023 17:37
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants