Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Safe version/upgrade button improvements #1627

Merged
merged 8 commits into from
Feb 6, 2023

Conversation

abheektripathy
Copy link
Contributor

@abheektripathy abheektripathy commented Feb 1, 2023

What it solves

Resolves #1530

Tasks-

  • Add a help link
  • If safe's upgraded, show latest version.
  • Upgrade notification

How this PR fixes it

Added a conditional that checks the Safe's state, if it's UP_TO_DATE shows Latest Version or else a link with the tooltip as mentioned.

How to test it

go to the settings page to verify your safe version.

Analytics changes

Screenshots

Screenshot 2023-02-01 at 5 40 16 PM

Screenshot 2023-02-01 at 5 58 04 PM

(for this screenshot i hardcoded the safe version to be OUTDATED)

@abheektripathy
Copy link
Contributor Author

@iamacook if the article's ready, lemme know. I'll link that.

Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, @abheektripathy - it looks very cool so far!

I have a few small suggestions.

src/components/settings/ContractVersion/index.tsx Outdated Show resolved Hide resolved
src/components/settings/ContractVersion/index.tsx Outdated Show resolved Hide resolved
src/components/settings/ContractVersion/index.tsx Outdated Show resolved Hide resolved
src/components/settings/ContractVersion/index.tsx Outdated Show resolved Hide resolved
@katspaugh katspaugh changed the title fixes-1530 fix: Safe version/upgrade button improvements Feb 1, 2023
src/components/settings/ContractVersion/index.tsx Outdated Show resolved Hide resolved
src/components/settings/ContractVersion/index.tsx Outdated Show resolved Hide resolved
src/components/settings/ContractVersion/index.tsx Outdated Show resolved Hide resolved
src/components/settings/ContractVersion/index.tsx Outdated Show resolved Hide resolved
abheektripathy and others added 4 commits February 3, 2023 14:17
Co-authored-by: Aaron Cook <aaron@safe.global>
Co-authored-by: Aaron Cook <aaron@safe.global>
Co-authored-by: Aaron Cook <aaron@safe.global>
@abheektripathy
Copy link
Contributor Author

@iamacook thanks for the review, i'll keep in mind to follow this code-style in the future.

@francovenica
Copy link
Contributor

francovenica commented Feb 3, 2023

Since an env is not created for these kind of tickets I ask Aaron to show it to me running it locally.
We checked there and it looks good. The tooltip is there when you hover the "i" icon and the Check of "Latest version" is fine.
We can merge it

We did a quick edit on the type of icon, because the original one (a square with a check) looks like a clickable checkbox:

Some snapshots
image
image

Note: there is a task about the notification that should not show up more than once. That task will be done in another ticket.
EDIT: OR it can be done by the same outside contributor, what ever is first

@iamacook
Copy link
Member

iamacook commented Feb 3, 2023

Thanks once again for the contribution, @abheektripathy!

Note: there is a task about the notification that should not show up more than once. That task will be done in another ticket.

If you'd like to tackle that as well @abheektripathy, you're more than welcome to! I think it would make sense in a separate PR.

3. Show the upgrade notification only once for a given Safe

If the user closed it, remember it and don't show it next time for that Safe unless 90 days passed.

@katspaugh
Copy link
Member

Thanks @abheektripathy!

@katspaugh katspaugh merged commit fcc7b26 into safe-global:dev Feb 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Safe upgrade] Add info on why users should upgrade
4 participants