Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: old app export link #1625

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Fix: old app export link #1625

merged 1 commit into from
Feb 1, 2023

Conversation

katspaugh
Copy link
Member

Fixes the link in the blue banner. The old app will redirect to the new app, except for the export path, so we shouldn't link to settings.

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Branch preview

✅ Deploy successful!

https://export_link--webcore.review-web-core.5afe.dev

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh katspaugh added this to the 1.4.5 milestone Feb 1, 2023
@katspaugh katspaugh mentioned this pull request Feb 1, 2023
@francovenica
Copy link
Contributor

LGTM.
Comparison old / new:
image
image

@katspaugh katspaugh merged commit aad18d9 into release/1.4.5 Feb 1, 2023
@katspaugh katspaugh deleted the export-link branch February 1, 2023 11:37
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2023
@francovenica
Copy link
Contributor

Ok, it was here as well. looks good
image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants