Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: prefix/chain id getters from one another #1619

Merged
merged 12 commits into from
Feb 6, 2023
Merged

refactor: prefix/chain id getters from one another #1619

merged 12 commits into from
Feb 6, 2023

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Jan 31, 2023 •
edited by liliya-soroka
Loading

What it solves

Resolves duplicate code

How this PR fixes it

Two new helpers, getShortName and getChainId have been created to get the respective values from one another.

How to test it

  1. Unknown networks should correctly show prefixes in the account center(wallet info).
  2. Navigating to a newly created Safe should work.
  3. Switching network should work.
  4. The header wallet info/wiget wallet info in Safe creation should show the prefixes of unknown networks correctly.

@iamacook iamacook self-assigned this Jan 31, 2023
@github-actions
Copy link

github-actions bot commented Jan 31, 2023 •
edited
Loading

Branch preview

✅ Deploy successful!

https://refactor_chains--webcore.review-web-core.5afe.dev

@github-actions
Copy link

github-actions bot commented Jan 31, 2023 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@katspaugh katspaugh mentioned this pull request Jan 31, 2023
Merged
katspaugh
katspaugh reviewed Jan 31, 2023
View reviewed changes
src/utils/chains.ts Outdated Show resolved Hide resolved
katspaugh
katspaugh reviewed Jan 31, 2023
View reviewed changes
src/utils/chains.ts Outdated Show resolved Hide resolved
Base automatically changed from unknown-network to dev January 31, 2023 12:32
@liliya-soroka
Copy link
Member

Verified

@iamacook iamacook merged commit 7606a09 into dev Feb 6, 2023
@iamacook iamacook deleted the refactor-chains branch February 6, 2023 15:26
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katspaugh katspaugh katspaugh approved these changes

Assignees

@iamacook iamacook

Labels
None yet
Projects
Web Squad
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iamacook @liliya-soroka @katspaugh