feat: default token list toggle #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
other changes: - Improved assets loading state
Branch preview✅ Deploy successful! https://spam_tokens_default_list--webcore.review-web-core.5afe.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
katspaugh
reviewed
Jan 26, 2023
katspaugh
reviewed
Jan 26, 2023
katspaugh
reviewed
Jan 26, 2023
iamacook
reviewed
Jan 26, 2023
| @@ -19,6 +19,43 @@ import useBalances from '@/hooks/useBalances' | |||
| import useHiddenTokens from '@/hooks/useHiddenTokens' | |||
| import { useHideAssets } from './useHideAssets' | |||
|
|
|||
| const skeletonCell = { | |||
There was a problem hiding this comment.
Nit: can we add the type for this to be safe.
Comment on lines
29
to
46
| <Skeleton width={'80px'} /> | ||
| </Typography> | ||
| </div> | ||
| ), | ||
| }, | ||
| balance: { | ||
| rawValue: '0', | ||
| content: ( | ||
| <Typography> | ||
| <Skeleton width={'32px'} /> | ||
| </Typography> | ||
| ), | ||
| }, | ||
| value: { | ||
| rawValue: '0', | ||
| content: ( | ||
| <Typography> | ||
| <Skeleton width={'32px'} /> |
There was a problem hiding this comment.
Suggested change
| <Skeleton width={'80px'} /> | |
| </Typography> | |
| </div> | |
| ), | |
| }, | |
| balance: { | |
| rawValue: '0', | |
| content: ( | |
| <Typography> | |
| <Skeleton width={'32px'} /> | |
| </Typography> | |
| ), | |
| }, | |
| value: { | |
| rawValue: '0', | |
| content: ( | |
| <Typography> | |
| <Skeleton width={'32px'} /> | |
| <Skeleton width="80px" /> | |
| </Typography> | |
| </div> | |
| ), | |
| }, | |
| balance: { | |
| rawValue: '0', | |
| content: ( | |
| <Typography> | |
| <Skeleton width="32px" /> | |
| </Typography> | |
| ), | |
| }, | |
| value: { | |
| rawValue: '0', | |
| content: ( | |
| <Typography> | |
| <Skeleton width="32px" /> |
iamacook
approved these changes
Jan 26, 2023
katspaugh
reviewed
Jan 31, 2023
ESLint Summary View Full Report
Report generated by eslint-plus-action |
- link to actual help article
|
|
@liliya-soroka as discussed:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #865
Todo
How this PR fixes it
tbd
How to test it
On staging CGW and görli / mainnet:
Analytics changes
tbd
Screenshots
tbd