Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: a/b tested promotion of hiding spam tokens #1504

Merged
merged 5 commits into from
Jan 10, 2023

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented Jan 9, 2023

What it solves

  • Adds a onboarding Tooltip to the new "hide token" button which will only be shown until dismissed.
  • the tooltip will only be shown to 50% of users to a/b test their efficiency.

How to test it

  1. Open the assets of a Safe
  2. If the tooltip is not shown, delete the SAFE_v2__AB_hide_token_promo entry in your local storage.
    2.1. Dismiss it => it should not come up again until the local storage is cleared

Analytics changes

None

Screenshots

Screenshot 2023-01-09 at 16 45 01

@github-actions
Copy link

github-actions bot commented Jan 9, 2023

Branch preview

✅ Deploy successful!

https://hide_token_onboarding_tooltip--webcore.review-web-core.5afe.dev

@github-actions
Copy link

github-actions bot commented Jan 9, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only thing I noticed is that the button text in dark mode is a bit hard to read on the white background. cc @liliiaorlenko

Screenshot 2023-01-10 at 10 35 03

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works well ✅

Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@katspaugh katspaugh merged commit bd19628 into dev Jan 10, 2023
@katspaugh katspaugh deleted the hide-token-onboarding-tooltip branch January 10, 2023 09:48
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants