-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: a/b tested promotion of hiding spam tokens #1504
Conversation
Branch preview✅ Deploy successful! https://hide_token_onboarding_tooltip--webcore.review-web-core.5afe.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Only thing I noticed is that the button text in dark mode is a bit hard to read on the white background. cc @liliiaorlenko
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works well ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
What it solves
How to test it
SAFE_v2__AB_hide_token_promo
entry in your local storage.2.1. Dismiss it => it should not come up again until the local storage is cleared
Analytics changes
None
Screenshots