Feat: allow switching wallet #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview✅ Deploy successful! |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
katspaugh
commented
Jan 6, 2023
| } | ||
|
|
||
| // A workaround for an onboard "feature" that shows a defunct account select popup | ||
| // See https://github.com/blocknative/web3-onboard/issues/888 |
There was a problem hiding this comment.
I mentioned our use case in a comment there.
usame-algan
approved these changes
Jan 9, 2023
|
I thought this was not possible. Glad to see it working I was able to switch between MM, WC (MM phone app), Trezor and Ledger with no issues for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #1490
How this PR fixes it
Instead of making the user disconnect to connect to another wallet, allow simply connecting in parallel.
How to test it
Analytics changes
None, but it should track the wallet each time