Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: async validation loader in AddressInput #1464

Merged
merged 2 commits into from
Jan 9, 2023

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented Dec 28, 2022

What it solves

Fixes async validation for AddressInput

Resolves #1203

How this PR fixes it

Shows a loading spinner while the form is validating.

How to test it

  • Find a address input with slow validation or add a way of throttling the validation (Slow resolving promise, network throttling)

@github-actions
Copy link

github-actions bot commented Dec 28, 2022

Branch preview

✅ Deploy successful!

https://fix_address_input_async_validation--webcore.review-web-core.5afe.dev

@github-actions
Copy link

github-actions bot commented Dec 28, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@DiogoSoaress DiogoSoaress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cherry on top 🍒 would be both spinners being sync but not worth the extra effort I guess.

@schmanu
Copy link
Member Author

schmanu commented Dec 28, 2022

@DiogoSoaress
The two spinners not in sync should also be the case when resolving ENS names. As it already displayed two spinners then.

I didnt find an easy way to achieve that. There is nothing in the MUI docs / examples.

@katspaugh katspaugh merged commit e1e196f into dev Jan 9, 2023
@katspaugh katspaugh deleted the fix-address-input-async-validation branch January 9, 2023 08:00
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add loading icon when the address check is in progress
3 participants