Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable no-constant-condition eslint rule #1381

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented Dec 16, 2022

What it solves

Enables no-constant-condition eslint rule which detects constant conditions such as

if ("constant" {
  doSomething()
}

How to test it

Add constant conditions in some code and see a warning appear.

@github-actions
Copy link

github-actions bot commented Dec 16, 2022

Branch preview

✅ Deploy successful!

https://eslint_no_constant_condition--webcore.review-web-core.5afe.dev

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@schmanu schmanu merged commit d78a606 into dev Dec 16, 2022
@schmanu schmanu deleted the eslint-no-constant-condition branch December 16, 2022 09:59
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants