fix: display factory and mastercopy known names in create tx info

[DiogoSoaress]

What it solves

Resolves #1347

How this PR fixes it

Passes mastercopy and factory known address names to the CreationTxInfo elements

How to test it

Expand a create tx info
(eth:0x92Db8FF884Fd2872888a61244FAEB1C50bf10cc3/transactions/history)

Screenshots

[github-actions]

Branch preview

✅ Deploy successful!

https://fix_known_addr_safe_creation--webcore.review-web-core.5afe.dev

[github-actions]

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

• Result: ✅ success
• Annotations: 0 total

---

^{Report generated by eslint-plus-action}

[iamacook]

Are you sure that these are "known addresses" on all networks? Afaiu, these need to have been manually named on the infra side.

[DiogoSoaress]

Are you sure that these are "known addresses" on all networks? Afaiu, these need to have been manually named on the infra side.

If the name is not know by the transaction services, it will display the one from AB or none.
We follow the same logic in safe-react https://github.com/safe-global/safe-react/blob/abcc2e420423662a632ae6dc33e1616cdc94c132/src/routes/safe/components/Transactions/TxList/TxInfoCreation.tsx#L28-L53

[iamacook]

If the name is not know by the transaction services, it will display the one from AB or none. We follow the same logic in safe-react https://github.com/safe-global/safe-react/blob/abcc2e420423662a632ae6dc33e1616cdc94c132/src/routes/safe/components/Transactions/TxList/TxInfoCreation.tsx#L28-L53

It won't show anything if there is no factory or implementation.

[DiogoSoaress]

Are you sure that these are "known addresses" on all networks?

If they are not known (not answered by the services) we simply don't display the Address name. How do you think it should behave? From my tests across networks they are always present.

[iamacook]

If they are not known (not answered by the services) we simply don't display the Address name. How do you think it should behave? From my tests across networks they are always present.

Your example from safe-react shows 'n/a' if no factory or implementation is returned. We're hiding them entirely.

Do we want to keep this logic and show the title with a pre-defined "empty state" or just hide them entirely? There is no design reference for this. cc @liliiaorlenko

[DiogoSoaress]

I've added a case to handle missing factory / mastercopy txInfo

mimics safe-react WDYT?

[iamacook]

Verified that this works well with known addresses with the address provided in the description.

[gitpoap-bot]

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2022 Safe Web Core Contributor:

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.