Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: div inside p #1322

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Fix: div inside p #1322

merged 1 commit into from
Dec 7, 2022

Conversation

katspaugh
Copy link
Member

@katspaugh katspaugh commented Dec 7, 2022

What it solves

Resolves #1320

How this PR fixes it

I've made the in a span instead of a div.

How to test

Delete the cookie consent from the local storage and reload the page. CookieBanner should appear and trigger a warning prior to this fix.

@github-actions
Copy link

github-actions bot commented Dec 7, 2022

Branch preview

✅ Deploy successful!

https://fix-p-div--webcore.review-web-core.5afe.dev

@github-actions
Copy link

github-actions bot commented Dec 7, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh katspaugh merged commit 2cf0712 into dev Dec 7, 2022
@katspaugh katspaugh deleted the fix-p-div branch December 7, 2022 17:00
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev warning: <div> cannot be descendent of <p>
2 participants