Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: link to old app from the import page #1306

Merged
merged 4 commits into from
Dec 5, 2022
Merged

Fix: link to old app from the import page #1306

merged 4 commits into from
Dec 5, 2022

Conversation

katspaugh
Copy link
Member

@katspaugh katspaugh commented Dec 5, 2022 •
edited by DiogoSoaress
Loading

  • Add a link to the old app on the import page
  • Make the tooltip text inline
  • Display "Overwrite data?" alert visible at all times

Screenshot 2022-12-05 at 08 44 06

@github-actions
Copy link

github-actions bot commented Dec 5, 2022 •
edited
Loading

Branch preview

✅ Deploy successful!

https://import-page--webcore.review-web-core.5afe.dev

@github-actions
Copy link

github-actions bot commented Dec 5, 2022 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions
Copy link

github-actions bot commented Dec 5, 2022 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@katspaugh katspaugh mentioned this pull request Dec 5, 2022
Merged
github-actions bot added a commit that referenced this pull request Dec 5, 2022
@github-actions
@katspaugh has signed the CLA from Pull Request #1306
5728ca8
@katspaugh
Copy link
Member Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Dec 5, 2022
@github-actions
@katspaugh has signed the CLA from Pull Request #1306
1a5d275
@iamacook
Copy link
Member

iamacook commented Dec 5, 2022

I've tested this and verified it works as expected.

@katspaugh katspaugh merged commit d6fe73e into dev Dec 5, 2022
@katspaugh katspaugh deleted the import-page branch December 5, 2022 08:40
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iamacook iamacook iamacook approved these changes

@schmanu schmanu Awaiting requested review from schmanu

Assignees
No one assigned
Labels
None yet
Projects
Web Squad
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katspaugh @iamacook