fix: vertical scrolling after opening the Mobile paring modal #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code looks good, thanks @metadiver! We're atm setting up a contributor agreement action, please give us some time to properly configure it, and then we can accept your PR. Cheers! |
katspaugh
changed the title
usame-algan
requested changes
Dec 5, 2022
|
thank you! |
|
@metadiver could you please add this to the PR description? Thanks! |
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2022 Safe Web Core Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #1281
How this PR fixes it
QRModal.ts manual handling of the Dialog is conflicting with mui's ModalManager, this PR is a workaround to remove the body styles manually after the modal is closed.
How to test it
Analytics changes
Screenshots
CLA
With the submission of this Pull Request, I confirm that I have read and agree to the terms of the Contributor License Agreement.