Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Account switching with mobile pairing and WC #1278

Merged
merged 2 commits into from
Nov 30, 2022
Merged

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Nov 29, 2022

What it solves

Resolves #1233

Opened a bug ticket in the onboard repo: blocknative/web3-onboard#1385

How this PR fixes it

  • Downgrades @web3-onboard/core to v2.8.5

How to test it

This can be tested either with WC or Mobile Pairing

  1. Open the Safe
  2. Connect via mobile app that has 2 owner keys
  3. Switch to the other owner via mobile app
  4. Observe the address updating on web
  5. Switch the chain via mobile app
  6. Observe the chain changing on web

@github-actions
Copy link

github-actions bot commented Nov 29, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest we add a note regarding the bug you found. Nice work otherwise.

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@usame-algan usame-algan merged commit c34012e into dev Nov 30, 2022
@usame-algan usame-algan deleted the fix-onboard branch November 30, 2022 11:16
@katspaugh katspaugh mentioned this pull request Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Mobile pairing] - Cannot switch the account connected to the web app
3 participants