Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Safe Core SDK from @safe-global #1266

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Import Safe Core SDK from @safe-global #1266

merged 1 commit into from
Nov 29, 2022

Conversation

germartinez
Copy link
Member

@germartinez germartinez commented Nov 28, 2022

What it solves

All the Safe Core SDK packages inside the monorepo have been published to our new npm organization: https://www.npmjs.com/org/safe-global

This pull request updates the Safe Core SDK dependencies and imports to use the new ones:

@safe-global/safe-core-sdk
@safe-global/safe-core-sdk-types
@safe-global/safe-ethers-lib

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 911d57d
Status: ✅  Deploy successful!
Preview URL: https://b70d8404.web-core.pages.dev
Branch Preview URL: https://import-core-sdk.web-core.pages.dev

View logs

@github-actions
Copy link

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@katspaugh
Copy link
Member

The build passes, so I'm going to merge this. The PR is only updating the SDK import paths.

@katspaugh katspaugh merged commit 33ae4fe into dev Nov 29, 2022
@katspaugh katspaugh deleted the import-core-sdk branch November 29, 2022 07:41
@gitpoap-bot
Copy link

gitpoap-bot bot commented Nov 29, 2022

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2022 Safe Web Core Contributor:

GitPOAP: 2022 Safe Web Core Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@katspaugh katspaugh mentioned this pull request Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants