Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Epic] Governance visibility #1256

Merged
merged 14 commits into from
Dec 9, 2022
Merged

[Epic] Governance visibility #1256

merged 14 commits into from
Dec 9, 2022

Conversation

DiogoSoaress
Copy link
Member

DiogoSoaress and others added 6 commits November 23, 2022 15:54
@DiogoSoaress
create the Governance section on Dashboard
1c9ad39
@DiogoSoaress
[Governance Visibility] Dashboard section (#1125)
5b3f681 
* dashboard section with placeholders

* use MUI Accordion for the collapsible section

* change expand icon color
@DiogoSoaress
feat: Dashboard governance widgets (#1149)
125a91f 
* feat: load a mini safe app in dashboard's Governance section

* fix card heights

* display snapshot widget

* fetch the claiming app and display the widgets

* fix: accordion defaultExpanded and fix loading states flicker

* responsive widgets grid

* expandDefault true

* no need to pass explicit boolean value. improve loading components
@DiogoSoaress
feat: pass dark mode in the widgets url (#1219)
bed2d28 
* expandDefault true

* no need to pass explicit boolean value. improve loading components

* feat: pass dark mode in the widgets url

* pass preferred them in a search parameter
@DiogoSoaress
feat: One governance widget (#1237)
3ee67ba 
* feat: call only one widget from the safe-claiming app

* rm unused Grid

* use widgetWrapper for the loading component

* add a custom fallback component

* ammend load error copy

* use different color in the placeholder as per design

* feat: dark flag in URL hash (#1251)
@DiogoSoaress
fix: governance widgets CSS (#1254)
5f936d9 
* fix: Accordion only clickable on expandIcon

* adjust AppFrame height for widgets

* change the widget load error component

* fix code style

* improve classnames params
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 28, 2022 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7b9b97b
Status: ✅  Deploy successful!
Preview URL: https://4c71c55c.web-core.pages.dev
Branch Preview URL: https://epic-governance.web-core.pages.dev

View logs

@DiogoSoaress DiogoSoaress marked this pull request as ready for review November 28, 2022 10:05
@github-actions
Copy link

github-actions bot commented Nov 28, 2022 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@github-actions
Copy link

Branch preview

https://pr1256--webcore.review-react-br.5afe.dev

@github-actions
Copy link

Branch preview

https://pr1256--webcore.review-web-core.5afe.dev

@iamacook
fix: return null if no Claiming App on chain (#1284)
2023e62 
* fix: return `null` if no Claiming App on chain

* fix: reference deployed token address

* fix: add address of token on Goerli

* fix: add loading wrapper

* fix: rename wrapper
@github-actions
Copy link

github-actions bot commented Dec 1, 2022 •
edited
Loading

Branch preview

✅ Deploy successful!

https://epic-governance--webcore.review-web-core.5afe.dev

@github-actions
Copy link

github-actions bot commented Dec 1, 2022

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Dec 5, 2022 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

katspaugh and others added 4 commits December 6, 2022 10:53
@katspaugh
Merge branch 'dev' of github.com:safe-global/web-core into epic-gover…
22e32aa 
…nance
@katspaugh
Fix: use a non-tracking version of the AppFrame (#1307)
867e08d 
* Fix: use a non-tracking version of the AppFrame

* Clear communicator handlers

* useAppIsLoading

* Rename components

* Extract getSafeInfo

* AppFrameWrapperProps -> AppFrameProps
@katspaugh
Merge branch 'dev' of github.com:safe-global/web-core into epic-gover…
4222e03 
…nance
@katspaugh
Fix: reload widget on safe change + catch errors (#1319)
4991d1d
@liliya-soroka
Copy link
Member

approved. Only the loading widget state is under question , but it's not critical for the feature

@katspaugh
Copy link
Member

Waiting for a final review from @yagopv.

@yagopv
Copy link
Member

yagopv commented Dec 9, 2022

Seems to be working fine @katspaugh, did some txs with Uni and Cow apps and checked returned data from the SDK with the test app. The code is fine for me, same we talked in the prev pr that was merged here.

useChainInfo is a refactor for removing code from AppFrame or is fixing something?

@katspaugh
Copy link
Member

@yagopv thanks! useGetSafeInfo you mean? It was requested by Aaron that I extract it so as to not repeat the same logic.

@yagopv
Copy link
Member

yagopv commented Dec 9, 2022

Oook!! Nice

@DiogoSoaress DiogoSoaress merged commit 8644e68 into dev Dec 9, 2022
@DiogoSoaress DiogoSoaress deleted the epic-governance branch December 9, 2022 12:59
@gitpoap-bot
Copy link

gitpoap-bot bot commented Dec 9, 2022

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2022 Safe Web Core Contributor:

GitPOAP: 2022 Safe Web Core Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yagopv yagopv yagopv approved these changes

@DaniSomoza DaniSomoza Awaiting requested review from DaniSomoza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Epic] Governance Visibility
5 participants
@DiogoSoaress @liliya-soroka @katspaugh @yagopv @iamacook