fix: improve reliability of E2E tests #1182
Conversation
Deploying with
|
| Latest commit: |
7c39833
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://61b28bb5.web-core.pages.dev |
| Branch Preview URL: | https://improve-tx-creation-test.web-core.pages.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
iamacook
changed the title
| @@ -15,8 +15,13 @@ describe('Queue a transaction on 1/N', () => { | |||
| }) | |||
|
|
|||
| it('should create and queue a transaction', () => { | |||
| // Assert that "New transaction" button is visible | |||
| cy.contains('New transaction', { | |||
| timeout: 60_000, // `lastWallet` takes a while initialize in CI | |||
There was a problem hiding this comment.
This is horribly long but 30s was sometimes too short. It doesn't seem to need this long but I'd sooner have it longer than necessary. As soon as the button is present, it continues.
There was a problem hiding this comment.
Why the long timeout in this assertion? There is no request before this modal opens.
If this is a bottleneck disregard my comment -> I thought the timeout would come only with the /estimations request
| @@ -15,8 +15,13 @@ describe('Queue a transaction on 1/N', () => { | |||
| }) | |||
|
|
|||
| it('should create and queue a transaction', () => { | |||
| // Assert that "New transaction" button is visible | |||
| cy.contains('New transaction', { | |||
| timeout: 60_000, // `lastWallet` takes a while initialize in CI | |||
There was a problem hiding this comment.
Why the long timeout in this assertion? There is no request before this modal opens.
If this is a bottleneck disregard my comment -> I thought the timeout would come only with the /estimations request
|
I can't reply to the comment directly for some reason so I will here.
The test was primarily failing because the last used wallet wasn't connecting in time as the logic "flow" is very long:
The timeout I added does not explicitly wait for 60s. If the wallet connects before then, the tests continue. |
What it solves
Unreliable transaction creation test.
How this PR fixes it
interceptcallbackHow to test it
Observe the test passes in the E2E job.