Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(safe-apps): Safe apps analysis improvements #1136

Merged
merged 6 commits into from
Nov 24, 2022

Conversation

yagopv
Copy link
Member

@yagopv yagopv commented Nov 14, 2022

What it solves

Add some fixes:

  • Duplicated "Open Safe App" event tracking
  • 404 when retrieving the apps default list and no chainId in redux store
  • Remove querystrings when storing url's from custom apps in analytics (We detect eth addresses there)

@yagopv yagopv marked this pull request as ready for review November 14, 2022 11:32
@github-actions
Copy link

github-actions bot commented Nov 14, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@yagopv yagopv changed the title Fix/safe apps analysis improvements fix(safe-apps): Safe apps analysis improvements Nov 14, 2022
@yagopv yagopv added safe-apps bug Something isn't working labels Nov 14, 2022
@yagopv yagopv self-assigned this Nov 14, 2022
Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

@liliya-soroka
Copy link
Member

Verified

@yagopv yagopv merged commit eac0216 into dev Nov 24, 2022
@yagopv yagopv deleted the fix/safe-apps-analysis-improvements branch November 24, 2022 10:35
@gitpoap-bot
Copy link

gitpoap-bot bot commented Nov 24, 2022

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2022 Safe Web Core Contributor:

GitPOAP: 2022 Safe Web Core Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@katspaugh katspaugh mentioned this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working safe-apps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants