Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove incoming transaction event #154

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Remove incoming transaction event #154

merged 1 commit into from
Dec 9, 2019

Conversation

rmeissner
Copy link
Member

As a result of the audit it was recommended to remove this event, because it is not dependable in the current implementation and might break with future gas changes.

@Georgi87 @Uxio0 what do you think?

@rmeissner
Copy link
Member Author

As a reference: ethereum/solidity#7455

Uxio0
Uxio0 approved these changes Dec 9, 2019
View reviewed changes
Copy link
Member

@Uxio0 Uxio0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it's ok, we have lived without that event until now. It would make things easier for web dapps, but for backend it will be the same. If audit recommended to remove it I'm ok with that

@rmeissner rmeissner merged commit ab37293 into development Dec 9, 2019
@rmeissner rmeissner deleted the feature/remove_incoming_event branch December 9, 2019 18:27
@rmeissner rmeissner modified the milestone: contracts-safe-1.1.1 Dec 9, 2019
fdarian pushed a commit to fdarian/safe-contracts that referenced this pull request Jan 14, 2024
@germartinez
Merge pull request safe-global#154 from gnosis/development
db232e0 
Development
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uxio0 Uxio0 Uxio0 approved these changes

@Georgi87 Georgi87 Awaiting requested review from Georgi87

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
contracts-safe-1.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@rmeissner @Uxio0